internal/resource: derive AWS region hint from ARN partition field #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For S3 access point ARNs, we derive the access point region from the region field in the ARN, allowing us to query the correct AWS partition. For regular S3 object ARNs, the region field is not used, so we assume the same partition Ignition is running in, or "aws" if running outside AWS. However, object ARNs include a valid partition field. Compute a region hint from that, and use it to ask the partition for the correct bucket region. That allows object ARNs to reference objects outside the current partition (when running in AWS) or outside the "aws" partition (when running outside AWS).
u.Host doesn't work for ARN URLs.
jlebon
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For S3 access point ARNs, we derive the access point region from the region field in the ARN, allowing us to query the correct AWS partition. For regular S3 object ARNs, the region field is not used, so we assume the same partition Ignition is running in, or
awsif running outside AWS.However, object ARNs include a valid partition field. Compute a region hint from that, and use it to ask the partition for the correct bucket region. That allows object ARNs to reference objects outside the current partition (when running in AWS) or outside the
awspartition (when running outside AWS).Followup to #1264.
cc @zeleena