Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting .d directory for base config fragments #1101

Closed
bgilbert opened this issue Sep 28, 2020 · 3 comments · Fixed by #1108 or coreos/fedora-coreos-config#676
Closed
Assignees

Comments

@bgilbert
Copy link
Contributor

We're starting to have divergence between the FCOS and RHCOS base configs (coreos/fedora-coreos-config#626), which requires the two distros to carry different base.ign files with common elements. Consider supporting a .d-style base config directory, where Ignition walks the directory and merges every config fragment in it.

@bgilbert
Copy link
Contributor Author

While we're here, we might also want to support an additional .d directory for each platform ID.

@lucab
Copy link
Contributor

lucab commented Sep 29, 2020

This looks like a useful generalization of the base.ign + user.ign merge 👍.
Among other things, right now base & user configs are explicitly identified by kind. @bgilbert were you planning to have separate base.d and user.d paths, or to only touch the former, or to get rid of the split, or something else?

@bgilbert
Copy link
Contributor Author

I was thinking this would only affect base configs for now. For user configs I think there's value in maintaining the current model, with a single well-defined root config that explicitly merges sub-configs. For base configs I think that's less important, since the "config built up from fragments" model is pretty well-understood in distro maintenance.

@sohankunkerkar sohankunkerkar self-assigned this Oct 5, 2020
@sohankunkerkar sohankunkerkar added the jira for syncing to jira label Oct 5, 2020
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 8, 2020
Fixes coreos#1101
This change was inspired by
coreos/fedora-coreos-config#626, which requires
the two distros to carry different base.ign files with common elements.
Also, this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 8, 2020
Fixes coreos#1101
This change was inspired by
coreos/fedora-coreos-config#626, which requires
the two distros to carry different base.ign files with common elements.
Also, this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 8, 2020
Fixes coreos#1101
This change was inspired by
coreos/fedora-coreos-config#626, which requires
the two distros to carry different base.ign files with common elements.
Also, this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 8, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which requires
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 9, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 15, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 15, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 22, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 22, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change was inspired by coreos/fedora-coreos-config#626, which allows
the two distros to carry different base.ign files with common elements. Also,
this will support an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 23, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 26, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 26, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 28, 2020
Fixes coreos#1101
This change allows the two distrosi (i.e. FCOS and RHCOS) to carry
different base.ign files with common elements. Also,this will support
an additional .d directory for each platform ID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants