-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Replace method to replace rulespec (in specified pos) #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hmm, not sure why checks aren't running. Lemme take a look. |
Let's try... closing and re-opening :-). |
@machooo-x can you fix the tests, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the tests.
Dear reviewer, hello. I am very sorry for taking so long to resolve this testing issue. Now that I have made changes, could you please take a look and help me merge if possible? If there are any further issues, please let me know and I will definitely solve them. :) |
If the test still fails, can you help me solve it conveniently? I can only consider doing this now. Thank you very much. |
I've re-triggered the tests - let's take a look :-). |
I'm very sorry for the delay in your time due to my mistake. I have fixed the issue that was just tested, please trigger the test again. : ) |
Dear reviewer, hello. If it's convenient, please trigger the workflow again and trigger the test. I need your help~~~ : ) |
Can you rebase this PR on top of the latest changes in the repo? This will make it easier to review. |
I have added this change to the latest branch. If there are any further issues, please let me know. : ) |
Dear member, if you have time, could you take a look at my changes this time? I want to know if it was successful. If not, I will follow your advice until it is successful. |
Dear squeed, will I appear on the list of contributors? @squeed |
That should happen automatically, unless there's something else you're thinking of. |
This change can support the modification of rules, and there is no conflict for the used items