Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop libvarlink-util from package set #1130

Closed
dustymabe opened this issue Mar 17, 2022 · 9 comments · Fixed by coreos/fedora-coreos-config#1721
Closed

Drop libvarlink-util from package set #1130

dustymabe opened this issue Mar 17, 2022 · 9 comments · Fixed by coreos/fedora-coreos-config#1721
Assignees
Labels
jira for syncing to jira status/decided

Comments

@dustymabe
Copy link
Member

This was originally added for podman-remote functionality but the podman team ripped out varlink code in v3. We should be safe to remove it but there may be some users using it for other things. I feel like if there was ever an opportunity for us to actually remove a package, this would be it.

@dustymabe dustymabe added the meeting topics for meetings label Mar 17, 2022
@jlebon
Copy link
Member

jlebon commented Mar 23, 2022

Notably, this removes /usr/bin/varlink.

@travier
Copy link
Member

travier commented Mar 23, 2022

I don't see a lot of activity in https://github.com/varlink/ and I don't know of major projects using it anymore.
If nothing uses it anymore in our default installation then it should be safe to remove. It can still be overlayed as needed for those that require it.

@dustymabe
Copy link
Member Author

We discussed this in the community meeting today.

12:58:29    dustymabe | #agreed We don't know of any other common uses of
                      | libvarlink-utils on FCOS right now. We'll try removing it
                      | from `next` and send an email about it to the list to see
                      | if that gives us any new information. After a period of
                      | time with no issues we'll promote that to `testing` and
                      | `stable`.

@dustymabe
Copy link
Member Author

dustymabe commented Mar 23, 2022

At this point we should:

  • send an email to the mailing lists notifying of the change
  • drop it from any branches other than testing-devel, testing, and stable.
  • wait some time and then drop it from the rest

@dustymabe dustymabe removed the meeting topics for meetings label Mar 23, 2022
@gursewak1997 gursewak1997 self-assigned this Mar 23, 2022
@dustymabe dustymabe added the jira for syncing to jira label Mar 23, 2022
@gursewak1997
Copy link
Member

gursewak1997 commented Apr 4, 2022

Draft email: Open to feedback

Subject: Fedora CoreOS dropping libvarlink-utils from base OSTree

We have decided to remove varlink (provided by the libvarlink-utils package) from Fedora CoreOS. Podman was the primary consumer of this package and the use of it was removed in Podman v3.0 and later [1]. At the moment, we are not aware of any other consumers of libvarlink-utils on FCOS.

The package will initially be removed from the next stream. It will be followed by testing and stable after it has been removed from next for at least a month.

The Fedora CoreOS Team

[1] https://podman.io/blogs/2020/08/01/deprecate-and-remove-varlink-notice.html#podman-api-v10-deprecation-and-removal-notice

@dustymabe
Copy link
Member Author

The fix for this went into next stream release 36.20220410.1.1. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. and removed status/pending-next-release Fixed upstream. Waiting on a next release. labels Apr 13, 2022
@dustymabe
Copy link
Member Author

Let's drop it from the other branches any time after 05/12/2022.

@dustymabe dustymabe changed the title Drop libvarlink-utils from package set Drop libvarlink-util from package set Apr 13, 2022
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 6, 2022
Now that we have waited an amount of time let's drop libvarlink-util
altogether.

Closes coreos/fedora-coreos-tracker#1130
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 6, 2022
Now that we have waited an amount of time let's drop libvarlink-util
altogether.

Closes coreos/fedora-coreos-tracker#1130
ravanelli pushed a commit to ravanelli/fedora-coreos-config that referenced this issue May 6, 2022
Now that we have waited an amount of time let's drop libvarlink-util
altogether.

Closes coreos/fedora-coreos-tracker#1130

(cherry picked from commit 0e50d9b)
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 7, 2022
Now that we have waited an amount of time let's drop libvarlink-util
altogether.

Closes coreos/fedora-coreos-tracker#1130

(cherry picked from commit 0e50d9b)
@dustymabe
Copy link
Member Author

The fix for this went into testing stream release 36.20220505.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. labels May 11, 2022
@dustymabe
Copy link
Member Author

The fix for this went into stable stream release 36.20220505.3.2.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label May 25, 2022
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Now that we have waited an amount of time let's drop libvarlink-util
altogether.

Closes coreos/fedora-coreos-tracker#1130
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Now that we have waited an amount of time let's drop libvarlink-util
altogether.

Closes coreos/fedora-coreos-tracker#1130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira status/decided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants