Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollout.py: Update location information #893

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

c4rt0
Copy link
Member

@c4rt0 c4rt0 commented Apr 23, 2024

Update location information; include time zones for all team members working on releases.

@c4rt0 c4rt0 requested review from dustymabe and jlebon April 23, 2024 12:01
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, this list is intended to represent the location of people involved in the release process. E.g. feel free to add Ireland to the list if you'd like (though looking it up, I guess that's UTC, which is already covered). Conversely, I don't think we have anyone in Germany involved in the release process anymore so we could also just drop that reference.

But we should probably add Vancouver, Colorado, and Brazil.

@c4rt0
Copy link
Member Author

c4rt0 commented Apr 23, 2024

Really, this list is intended to represent the location of people involved in the release process. E.g. feel free to add Ireland to the list if you'd like (though looking it up, I guess that's UTC, which is already covered). Conversely, I don't think we have anyone in Germany involved in the release process anymore so we could also just drop that reference.

But we should probably add Vancouver, Colorado, and Brazil.

Thanks for the explanation, I didn't catch for whom this was intended.
Since Germany is under one and the very same time zone as France and Poland I will still leave it in... we have folks in there who might do some work on releases in the future.
Ireland is in a different time zone. I will add it with the locations suggested above in the next push.

@c4rt0 c4rt0 force-pushed the pr/update_rollout branch from 79ae36b to 15b4431 Compare April 23, 2024 16:28
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit longer than I thought (I guess we don't have many people sharing time zones) but meh, cool with it. Thanks!

@c4rt0 c4rt0 requested a review from yasminvalim April 25, 2024 08:03
@c4rt0 c4rt0 merged commit ba98484 into coreos:main Apr 25, 2024
1 check passed
@c4rt0 c4rt0 deleted the pr/update_rollout branch April 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants