Roll out stable 38.20231027.3.1, testing 39.20231101.2.0, next 39.20231106.1.0 #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Nov 7, 2023
jlebon
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
"Check stream diffs" is complaining about fedora-coreos-stream-generator. I think it expects the latest tagged version, but the rollout workflow builds it from git main. We should tweak the differ so it uses git describe like the generator itself does so we don't have to tag after every commit.
marmijo
approved these changes
Nov 7, 2023
jlebon
added a commit
to jlebon/fedora-coreos-streams
that referenced
this pull request
Nov 7, 2023
The rollout workflow currently builds the generator from `git main` but the stream diff workflow expects that we use the generator from the latest tagged version. Modify the latter so that it also uses `git describe` from `main`. See: coreos#807 (review)
Should be fixed by #808. |
jlebon
added a commit
that referenced
this pull request
Nov 7, 2023
The rollout workflow currently builds the generator from `git main` but the stream diff workflow expects that we use the generator from the latest tagged version. Modify the latter so that it also uses `git describe` from `main`. See: #807 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @marmijo via GitHub workflow (source).