jobs/build: don't try to complete ongoing builds #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only actually run the jobs when `uploading` is set. So it seems wrong to update the build description. In fact, let's not even waste time looking for missing arches or reading build metadata. Patch best viewed with whitespace ignored.
|
alternative in #823 |
dustymabe
reviewed
Feb 27, 2023
jlebon
force-pushed
the
pr/build-race
branch
2 times, most recently
from
e011c4d to
ce91c98
Compare
dustymabe
reviewed
Feb 27, 2023
Since 973bcf9 ("jobs/build: rerun `build-arch` if previous build is incomplete"), there is a race possible where the `build` job rerun logic could kick in before the `release` jobs initially triggered for that build has finished. We don't want to queue builds in that case. Gate the rerun logic on whether the multi-arch locks and release lock are taken. It's theoretically possible but highly unlikely that we probe the lock status before the previous `release` job takes it. Ideally, we would have a way to directly take the lock and "transfer" its ownership to the job we trigger. Anyway, if that somehow happens, it would result in the job being run twice, which is safe.
jlebon
force-pushed
the
pr/build-race
branch
from
ce91c98 to
696a572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 973bcf9 ("jobs/build: rerun
build-archif previous build isincomplete"), there is a race possible where the
buildjob rerun logiccould kick in before the
releasejobs initially triggered for thatbuild has finished. We don't want to queue builds in that case.
Gate the rerun logic on whether the multi-arch locks and release lock
are taken.
It's theoretically possible but highly unlikely that we probe the lock
status before the previous
releasejob takes it. Ideally, we wouldhave a way to directly take the lock and "transfer" its ownership to the
job we trigger. Anyway, if that somehow happens, it would result in the
job being run twice, which is safe.