-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs so we can use jenkins:2 #70
Conversation
d2a1ef3
to
2116e1f
Compare
i'm going to cascade these PRs so I can test them all together - now requires #64 |
To confirm, nothing actually breaks today as a result of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny optional comment, otherwise LGTM!
needed once we are running on a newer version of OpenShift than 3.6 in | ||
CentOS CI. See [#32](https://github.com/coreos/fedora-coreos-pipeline/pull/32) | ||
and [#70](https://github.com/coreos/fedora-coreos-pipeline/pull/70) | ||
for context on why this may be needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super minor/OCD, though can we consistently capitalize Jenkins and OpenShift? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - let me know if you spot any I missed
e06f389
to
28ab585
Compare
Every time i deploy in newer openshift (pretty much anything other than centos ci as that's the only remaining openshift 3.6 cluster I know of) I have to The alternative to this approach is that we add that The reason I settled on the current approach is because you should be able to run the command I've added to the docs regardless of what version you are on and it should be a no-op if you are on a version that is new enough. So slightly less confusing. |
Update the docs so that we can be more compatible with latest templates. We update the input ImageStreamTag for our Jenkins deployment to match latest OpenShift (`jenkins:2`) related: coreos#32
Update the docs so that we can be more compatible with latest templates.
We update the input ImageStreamTag for our jenkins deployment to match
latest openshift (
jenkins:2
)related: #32