s390x: Add builder config for RHCOS #679
Conversation
|
I am unsure wether or not we want the ignition files in here. They are needed for the LPAR installation, since i need to fetch them over http(s) and this is the easiest way for me. However i guess technically they count as artifacts and not source code. |
|
Thanks for working on this @jschintag - I'll look at it on Monday when I'm back. |
|
No problem @dustymabe, i generally don't expect reviews on Fridays :) |
jschintag
force-pushed
the
s390x-lpar
branch
2 times, most recently
from
035875a to
69ff4e7
Compare
|
Since i noticed this one was still open, i added the changes to initialize the secure execution volume during installation here. |
|
@jschintag I think for now let's leave the generated I understand why it's useful to have them there but I think it causes more problems than it solves. If we did end up wanting to store them in git I think we should probably front that with a github action or some CI to validate that the |
|
@dustymabe Yes, i wasn't sure about the ignition files either. I removed them.
Since we already have an internal how-to on how to deploy the RHCOS Builder, with instructions for the specific hardware, i think it does not make sense do add that bit here. |
jschintag
force-pushed
the
s390x-lpar
branch
from
f2ae887 to
009d581
Compare
| ignition: | ||
| config: | ||
| merge: | ||
| - source: http://foo/bar/builder-common.ign |
There was a problem hiding this comment.
I think we can use local here instead of source to use a locally generated file.
See
There was a problem hiding this comment.
No, since in order to install it on LPAR, we need to fetch the files over http(s). That is why i have the placeholder here.
jschintag
force-pushed
the
s390x-lpar
branch
from
009d581 to
4022fe5
Compare
|
I think in the latest update we lost setting the hostname to something different. Not sure if that was intended or not. |
jschintag
force-pushed
the
s390x-lpar
branch
from
4022fe5 to
4f9197d
Compare
Yes, i lost it intentionally since it is not really needed to keep the hostname of the machine special. |
| # - Merge in the builder-common.ign Ignition file | ||
| # - Allow the builder user to log in with the associated ssh key | ||
| # - Set a hostname | ||
| # - Create and initialize the secex-data volume |
There was a problem hiding this comment.
This needs updating:
| # - Merge in the builder-common.ign Ignition file | |
| # - Allow the builder user to log in with the associated ssh key | |
| # - Set a hostname | |
| # - Create and initialize the secex-data volume | |
| # - Merge in the coreos-s390x-builder.ign Ignition file | |
| # - Create and initialize the secex-data volume |
Might have to be split across the two commits you have in this PR.
There was a problem hiding this comment.
I updated the description accordingly and split it between the 2 commits
Add the builder config for the s390x RHCOS builder. Signed-off-by: Jan Schintag <[email protected]>
Add a script to initialize secex-data volume during installation. This is achieved by having the tarball stored on a second disk. Also run a podman container that mounts the volume to keep it from being pruned. See: containers/podman#17051 Signed-off-by: Jan Schintag <[email protected]>
Add the builder config for the s390x RHCOS builder. Add ignition files for both so that they can be fetched during installation.
Signed-off-by: Jan Schintag [email protected]