muliti-arch-builders/splunk: only build the splunk sidecar container #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repo we are using to build the ITPAAS splunkforwarder container on the RHCOS multi-arch builders is out of date and references a splunkforwarder rpm that no longer exists in the internal repos. By omitting the build step for this container, we can pull in the already built image from ITPAAS that includes a more recent RPM. We'll still use `--arch=x86_64` for the sidecar container to ensure proper logging on non x86_64 builders. See: coreos#1044
|
previously we weren't pulling any containers from $internal, we were accessing internal git repos but we weren't pulling any containers from internal registries. (IIUC) are we sure we will be able to pull from those registries? one way to check is to log in to the various multi-arch builders and |
yes, we can pull from that registry. I've already restarted the splunk container on the RHCOS |
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo we are using to build the ITPAAS splunkforwarder container on the RHCOS multi-arch builders is out of date and references a splunkforwarder rpm that no longer exists in the internal repos. By omitting the build step for this container, we can pull in the already built image from ITPAAS that includes a more recent RPM.
We'll still use
--arch=x86_64for the sidecar container to ensure proper logging on non x86_64 builders.See: #1044