Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Raspberry Pi 4 #336

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

dustymabe
Copy link
Member

No description provided.

@dustymabe dustymabe marked this pull request as draft November 2, 2021 20:42
@dustymabe
Copy link
Member Author

Going to run through the various steps one more time to make sure all is well and nothing got lost in translation.

@dustymabe dustymabe marked this pull request as ready for review November 3, 2021 20:47
@dustymabe
Copy link
Member Author

OK. I tested all the cases now and verified everything worked. Anyone open for reivews? I'm hoping to not change the steps too much since I've already tested them, but can if needed.

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a lot. Thanks for writing it up!

LGTM generally, mostly nits.

modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
@miabbott
Copy link
Member

miabbott commented Nov 4, 2021

I can be a tester for this; I've got an RPi4 that is unused at the moment. Will try to run through this tomorrow.

@dustymabe dustymabe force-pushed the dusty-pi4-docs branch 2 times, most recently from 5fd5fa7 to d7aaeba Compare November 4, 2021 14:48
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, just the nohighlight and one nit.

modules/ROOT/pages/provisioning-raspberry-pi4.adoc Outdated Show resolved Hide resolved
@dustymabe
Copy link
Member Author

OK I think I've addressed all code review comments.

@dustymabe dustymabe force-pushed the dusty-pi4-docs branch 3 times, most recently from 414d3a4 to 1ab13f4 Compare November 4, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants