Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faq: add an entry for BIOS/UEFI boot modes #102

Merged
merged 5 commits into from
Jul 22, 2020

Conversation

nasirhm
Copy link
Contributor

@nasirhm nasirhm commented Jul 20, 2020

According to issue: #100

  • A faq entry added for Hybrid boot on Metal.
  • On the /bare-metal page, there's already a note stating it.
  • On the /platforms page, It's already written there with metal as well.


== Are Fedora CoreOS disk images hybrid BIOS+UEFI bootable?

The bare metal images we provide can be used for either BIOS (legacy) boot or UEFI boot, You can boot it in either BIOS (legacy) or UEFI mode regardless of what mode the OS will use once installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mixed up a bunch of statements here, the second part is usually found in the context of booting the live-ISO (in order to image a bare-metal disk).

@lucab lucab changed the title A faq entry for Hybrid Boot on metal is added. faq: add an entry for BIOS/UEFI boot modes Jul 21, 2020
@lucab
Copy link
Contributor

lucab commented Jul 21, 2020

@nasirhm thanks for the patch! I've left a comment in review, I think you can make the entry simpler without the second part.

…he context of booting the live-ISO (in order to image a bare-metal disk).
@nasirhm
Copy link
Contributor Author

nasirhm commented Jul 21, 2020

Hey @lucab , here's the path: dec125e

@nasirhm
Copy link
Contributor Author

nasirhm commented Jul 22, 2020

Thank You @dustymabe for the review and updates.

@dustymabe
Copy link
Member

Sigh, I forgot this was adoc and not markdown.. New suggestion to fix the links..

Co-authored-by: Dusty Mabe <[email protected]>
@nasirhm
Copy link
Contributor Author

nasirhm commented Jul 22, 2020

Oops, I didn't see it as well. Thanks @dustymabe .

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but LGTM overall! (One procedural note: can we squash all these into a single commit?)


== Are Fedora CoreOS x86_64 disk images hybrid BIOS+UEFI bootable?

The x86_64 images we provide can be used for either BIOS (legacy) boot or UEFI boot. They contain a hybrid BIOS/UEFI partition setup that allows them to be used for either. The exception to that is the `metal4k` 4k native image, which is targeted at disks with 4k sectors and https://github.com/coreos/coreos-assembler/blob/12029fea7798fa5d3535eafcf8c3d02f9a6095e4/src/cmd-buildextend-metal#L200-L202[does not have a BIOS boot partition] because 4k native disks are https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/hard-drives-and-partitions#advanced-format-drives[only supported with UEFI].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth linking to cosa code, but meh. Hmm, also wish we had a better link than the Microsoft one, but I can't find one offhand, so WFM! (I found https://lwn.net/Articles/377895/ though that might be too detailed.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the existing link is fine. I'm sure it'll break at some point and we'll fix it.


== Are Fedora CoreOS x86_64 disk images hybrid BIOS+UEFI bootable?

The x86_64 images we provide can be used for either BIOS (legacy) boot or UEFI boot. They contain a hybrid BIOS/UEFI partition setup that allows them to be used for either. The exception to that is the `metal4k` 4k native image, which is targeted at disks with 4k sectors and https://github.com/coreos/coreos-assembler/blob/12029fea7798fa5d3535eafcf8c3d02f9a6095e4/src/cmd-buildextend-metal#L200-L202[does not have a BIOS boot partition] because 4k native disks are https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/hard-drives-and-partitions#advanced-format-drives[only supported with UEFI].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for the first sentence we can add the words "bare metal" since that's how it's labeled in the download page, e.g.:

The x86_64 bare metal images we provide can be used for either BIOS (legacy) boot or UEFI boot.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it generic. I would have claimed otherwise, but the truth is that this isn't limited to our bare metal images. From looking at the code the only x86_64 image we create that isn't hybrid is the 4kn disk image. Am I reading it correctly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's true. Though OTOH it's not like it matters much for most other platforms, and although I love the consistency, it's possible we may change it in the future (see e.g. coreos/fedora-coreos-config#407) and should reverse the right to break that.

No strong opinion either way though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's merge as-is then.

@dustymabe dustymabe merged commit 2d093e4 into coreos:master Jul 22, 2020
@dustymabe
Copy link
Member

Thanks @nasirhm

@nasirhm
Copy link
Contributor Author

nasirhm commented Jul 22, 2020

Thank you for the opportunity @dustymabe =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants