Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: Use labels root and boot #7

Merged
merged 1 commit into from
Sep 13, 2018
Merged

image: Use labels root and boot #7

merged 1 commit into from
Sep 13, 2018

Conversation

cgwalters
Copy link
Member

This makes it easier for other tools (e.g. the oemid injection script)
to discover the partitions without hardcoding the layout.

Prep for dropping LVM.

This makes it easier for other tools (e.g. the oemid injection script)
to discover the partitions without hardcoding the layout.

Prep for dropping LVM.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 13, 2018
Requires: coreos/fedora-coreos-config#7

Prep for dropping LVM - but in general this adds a level of flexibility,
if someone wants to use some other filesystem or LVM setup they
can just provide those same labels.
Copy link
Contributor

@ajeddeloh ajeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cgwalters added a commit to coreos/coreos-assembler that referenced this pull request Sep 13, 2018
Requires: coreos/fedora-coreos-config#7

Prep for dropping LVM - but in general this adds a level of flexibility,
if someone wants to use some other filesystem or LVM setup they
can just provide those same labels.
@cgwalters cgwalters merged commit 0fdb511 into master Sep 13, 2018
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 17, 2018
Requires: coreos/fedora-coreos-config#7

Prep for dropping LVM - but in general this adds a level of flexibility,
if someone wants to use some other filesystem or LVM setup they
can just provide those same labels.
cgwalters added a commit to coreos/coreos-assembler that referenced this pull request Sep 17, 2018
Requires: coreos/fedora-coreos-config#7

Prep for dropping LVM - but in general this adds a level of flexibility,
if someone wants to use some other filesystem or LVM setup they
can just provide those same labels.
@dustymabe dustymabe deleted the use-labels branch September 19, 2018 14:55
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
dustymabe added a commit to jbtrystram/fedora-coreos-config that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants