-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/manual: update the net test script to support RHCOS #369
tests/manual: update the net test script to support RHCOS #369
Conversation
This should help us test against cases like coreos/fedora-coreos-tracker#466
This is useful for development.
This makes it so we can call coreos-network-testing.sh with either a rhcos qcow or a fcos qcow. Depending on the name of the file the script will act differently.
This will allow us to ssh into machines that use dhcp in the real root. It uses ARP via `ip neighbor` to find the IP based on the MAC.
This is to test that network propagation will be skipped if the user's provided ifcfg files via Ignition.
Yes. At least some of this coverage needs to be ported into kola tests so that they run as part of our CI runs. |
Unless we are in a hurry, this looks like a great time and incentive to move this "testing logic for RHCOS" out of this "configuration repo for FCOS", doesn't it? |
Hmm...there's a lot of shared code though. The subject of a separate repo for tests also came up in coreos/coreos-assembler#1407 (comment) |
I don't have any magic bullets here on where this should live. I don't know of a better place right now. |
I may have misunderstood something. Wasn't |
Moving to the coreos-assembler repository does make more sense than this repo I would agree. (But, conflicts a bit with the exttest direction of having cosa be a mechanism and not as much policy) |
coreos/fedora-coreos-tracker#340 effectively covers "our testing and libvirt". |
Update the net test to support RHCOS and also add some new tests.