Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/manual: update the net test script to support RHCOS #369

Merged
merged 11 commits into from
May 8, 2020

Conversation

dustymabe
Copy link
Member

Update the net test to support RHCOS and also add some new tests.

This makes it so we can call coreos-network-testing.sh with either
a rhcos qcow or a fcos qcow. Depending on the name of the file the
script will act differently.
This will allow us to ssh into machines that use dhcp in the real
root. It uses ARP via `ip neighbor` to find the IP based on the MAC.
This is to test that network propagation will be skipped if the user's
provided ifcfg files via Ignition.
@dustymabe
Copy link
Member Author

Yes. At least some of this coverage needs to be ported into kola tests so that they run as part of our CI runs.

@lucab
Copy link
Contributor

lucab commented Apr 29, 2020

At least some of this coverage needs to be ported into kola tests so that they run as part of our CI runs.

Unless we are in a hurry, this looks like a great time and incentive to move this "testing logic for RHCOS" out of this "configuration repo for FCOS", doesn't it?

@cgwalters
Copy link
Member

Unless we are in a hurry, this looks like a great time and incentive to move this "testing logic for RHCOS" out of this "configuration repo for FCOS", doesn't it?

Hmm...there's a lot of shared code though.

The subject of a separate repo for tests also came up in coreos/coreos-assembler#1407 (comment)

@dustymabe
Copy link
Member Author

I don't have any magic bullets here on where this should live. I don't know of a better place right now.

@lucab
Copy link
Contributor

lucab commented Apr 30, 2020

I may have misunderstood something. Wasn't kola the planned place where these kinds of tests (and setup logic too) would live?
My understanding is that it was here temporarily as a manual stopgap during development, to be moved into automated CI once we were comfortable with the direction of the underlying logic.

@cgwalters
Copy link
Member

Moving to the coreos-assembler repository does make more sense than this repo I would agree. (But, conflicts a bit with the exttest direction of having cosa be a mechanism and not as much policy)

@cgwalters
Copy link
Member

coreos/fedora-coreos-tracker#340 effectively covers "our testing and libvirt".

@cgwalters cgwalters merged commit bd3ee66 into coreos:testing-devel May 8, 2020
@dustymabe dustymabe deleted the dusty-nettest-updates branch May 8, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants