Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rawhide] overrides: remove json-glib pin #3117

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Aug 21, 2024

There is a fix upstream for the issue, but we can just add the broken
symlink to the allowlist for the kola test 'validate-symlinks' and
unpin to pick up the latest f42 package.

see: https://bugzilla.redhat.com/show_bug.cgi?id=2297094

@marmijo
Copy link
Member Author

marmijo commented Aug 21, 2024

This will need a rebase and a quick edit after #3115 merges

@travier
Copy link
Member

travier commented Aug 22, 2024

Let's hold for #3115

@jlebon
Copy link
Member

jlebon commented Aug 26, 2024

Once the config-bot syncs over the test changes from #3109 to rawhide, we can rebase this to just be about the overrides removal.

@travier
Copy link
Member

travier commented Aug 28, 2024

Does the bot really syncs branched commits to rawhide?

@travier travier force-pushed the rawhide-ignore-json-glib-symlink branch 2 times, most recently from 4db0abc to b32acd1 Compare August 28, 2024 14:06
@jlebon
Copy link
Member

jlebon commented Aug 28, 2024

Does the bot really syncs branched commits to rawhide?

#3109 (comment)

@travier
Copy link
Member

travier commented Aug 29, 2024

Will rebase on top of #3129

There is a fix upstream for the issue, but we can just add the broken
symlink to the allowlist for the kola test 'validate-symlinks' and
unpin to pick up the latest f42 package.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2297094
See: coreos#3129
@travier travier force-pushed the rawhide-ignore-json-glib-symlink branch from b32acd1 to 4c05d1f Compare August 29, 2024 13:32
@dustymabe dustymabe changed the title [rawhide] Ignore json-glib broken symlink and unpin [rawhide] overrides: remove json-glib pin Aug 29, 2024
@dustymabe
Copy link
Member

since #3129 merged and has synced to the rawhide branch (via config-bot) now all that is left to do here is drop the pin.

This PR has been updated by @travier to do just that.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) August 29, 2024 13:34
@dustymabe dustymabe merged commit 6c7dc68 into coreos:rawhide Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants