Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next-devel] manifest: point next-devel at f32 #306

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Mar 17, 2020

This branch is forked from the testing-devel branch to start a
next-devel stream which will currently track f32. This is something we
should've done for a while now.

@jlebon jlebon added the WIP PR still being worked on label Mar 17, 2020
@jlebon
Copy link
Member Author

jlebon commented Mar 17, 2020

Still working on getting the packages updated to f32.

@jlebon
Copy link
Member Author

jlebon commented Mar 17, 2020

https://src.fedoraproject.org/rpms/skopeo/pull-request/6

With this, I get a successful compose, though I haven't sanity-checked it much yet.

@jlebon
Copy link
Member Author

jlebon commented Mar 19, 2020

The other fix that was needed is coreos/coreos-assembler#1260.

This is now blocked on https://src.fedoraproject.org/rpms/skopeo/pull-request/6.

@jlebon jlebon added the hold label Mar 19, 2020
@jlebon jlebon force-pushed the pr/next-devel-f32 branch 2 times, most recently from 07592e0 to af08a6c Compare March 20, 2020 18:06
@jlebon jlebon removed WIP PR still being worked on hold labels Mar 20, 2020
jlebon added a commit to jlebon/fedora-coreos-config that referenced this pull request Mar 20, 2020
E.g. on `next-devel` we want CI to `buildprep` from the `next-devel`
stream.

Required for green CI in:
coreos#306
@jlebon
Copy link
Member Author

jlebon commented Mar 20, 2020

OK, dropping WIP and hold on this! This passes kola tests locally for me!
There's some weird things going on though, e.g. I'm getting output like:

--- PASS: podman.network-single (218.36s)
        cluster.go:122: Getting image source signatures
        cluster.go:122: Copying blob sha256:770d4472798aba01b2f87006ab973ef787bab52a0ee838d38bfcaed650d0a4de
        cluster.go:122: Copying config sha256:3544563b0974d8004ea6c8ddb9a39972212edd2567dcd00ec5bc0fdef8529ce5
        cluster.go:122: Writing manifest to image destination
        cluster.go:122: Storing signatures
        cluster.go:122: time="2020-03-20T17:08:55Z" level=error msg="Error forwarding signal 23 to container 50369571ba787a569fc21910aae"
        cluster.go:122: time="2020-03-20T17:08:57Z" level=error msg="Error forwarding signal 23 to container 5bf7f4254f2ffaa4bb6ccd5495c"
        cluster.go:122: time="2020-03-20T17:08:59Z" level=error msg="Error forwarding signal 23 to container 650d6243ebeee2b06ea233f040b"
        cluster.go:122: time="2020-03-20T17:09:01Z" level=error msg="Error forwarding signal 23 to container 6d69fed616e0f1de421fa915be3"
        cluster.go:122: time="2020-03-20T17:09:03Z" level=error msg="Error forwarding signal 23 to container 608e33542d1de92c1d8ee7442b8"
        cluster.go:122: time="2020-03-20T17:09:05Z" level=error msg="Error forwarding signal 23 to container d1fa8e95b666917cb36c9091d29"
...

But the test itself still passes. So we can investigate that later.

@jlebon
Copy link
Member Author

jlebon commented Mar 20, 2020

We also need #312.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just tedious stuff to point out changes to see if there is any action we need to take

},
"brotli": {
"evra": "1.0.7-6.fc31.x86_64"
"evra": "32:9.11.14-5.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped brotli

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped compression dep of libcurl in exchange for libbrotli. So net effect is we're dropping /usr/bin/brotli.. I'd say let's keep it out and see if anyone complains.

"evra": "1.4.4-2.fc31.x86_64"
},
"freetype": {
"evra": "2.10.0-3.fc31.x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped freetype

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a dep of grub2-tools-extra. Used for font rendering.

},
"grub2-tools-extra": {
"evra": "1:2.02-105.fc31.x86_64"
"evra": "1:2.04-9.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped grub2-tools-extra

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped dep of grub2-{efi,pc}. Had a few less common GRUB utilities, but not grub2-mkconfig. (And actually, I think one thing discussed in the past is getting rid of even that...)

Comment on lines +489 to 482
"libcbor": {
"evra": "0.5.0-7.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added libcbor

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dep of libfido2.

Comment on lines +528 to 521
"libfido2": {
"evra": "1.3.1-1.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added libfido2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dep of openssh-clients. Looks like enablement for authentication via U2F/Yubikeys.

Comment on lines +543 to 536
"libicu": {
"evra": "65.1-2.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added libicu

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dep of samba-client-libs. Looks like Unicode database and utility library.

And... oufff 33M. That one might be worth a closer look.

Comment on lines -615 to 608
"libpng": {
"evra": "2:1.6.37-2.fc31.x86_64"
"evra": "1.6.3-3.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped libpng

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a dep of freetype.

Comment on lines +480 to 473
"libbrotli": {
"evra": "1.0.7-10.fc32.x86_64"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added libbrotli

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New deps of libcurl in exchange for brotli.

jlebon added a commit that referenced this pull request Mar 20, 2020
E.g. on `next-devel` we want CI to `buildprep` from the `next-devel`
stream.

Required for green CI in:
#306
@dustymabe
Copy link
Member

can we add this to the overrides: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f56f55391d

dustymabe pushed a commit to dustymabe/fedora-coreos-config that referenced this pull request Mar 25, 2020
E.g. on `next-devel` we want CI to `buildprep` from the `next-devel`
stream.

Required for green CI in:
coreos#306

(cherry picked from commit 9321003)
dustymabe pushed a commit that referenced this pull request Mar 25, 2020
E.g. on `next-devel` we want CI to `buildprep` from the `next-devel`
stream.

Required for green CI in:
#306

(cherry picked from commit 9321003)
@jlebon jlebon force-pushed the pr/next-devel-f32 branch from af08a6c to f17c9d3 Compare April 3, 2020 18:58
@jlebon
Copy link
Member Author

jlebon commented Apr 3, 2020

can we add this to the overrides: bodhi.fedoraproject.org/updates/FEDORA-2020-f56f55391d

Looks like it's already in f32 repos now.

@jlebon
Copy link
Member Author

jlebon commented Apr 3, 2020

OK, coreos-koji-tagger support merged and rolled out! I think we're just missing coreos/coreos-assembler#1318 and then we can get this in?

Re. libicu, let's just track that in an issue and go from there so we can at least start building this stream?

@jlebon
Copy link
Member Author

jlebon commented Apr 3, 2020

Peeled off investigations of libicu into coreos/fedora-coreos-tracker#452.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlebon added 2 commits April 7, 2020 14:56
This branch is forked from the testing-devel branch to start a
next-devel stream which will currently track f32. This is something we
should've done for a while now.
This actually seeds the lockfiles with the starting set of packages to
use on f32.
@jlebon jlebon force-pushed the pr/next-devel-f32 branch from 40db68b to e61d6b8 Compare April 7, 2020 19:20
@jlebon
Copy link
Member Author

jlebon commented Apr 7, 2020

OK, this now needs coreos/coreos-ci-lib#19 too.

We don't have a previous `next-devel` build yet that the upgrade tests
can use as the "parent" build. As mentioned in [1], we could force it to
use the testing-devel stream. But actually I'd like to enhance CI more
generally so it covers both of these cases (from `testing-devel` to
`next-devel` and within `next-devel` as well). For now, let's just focus
on getting f32-based FCOS off the ground.

And as mentioned in the Jenkinsfile, this will be automatically reverted
by config-bot when it next syncs the file from the `testing-devel`
branch.

[1] coreos/coreos-ci-lib#19
@jlebon jlebon force-pushed the pr/next-devel-f32 branch from 5e6b754 to ca10e1d Compare April 7, 2020 20:20
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 31f195d into coreos:next-devel Apr 7, 2020
@jlebon jlebon deleted the pr/next-devel-f32 branch April 7, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants