Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rawhide] overrides: pin systemd-255.5-1.fc41 #3004

Merged
merged 2 commits into from
May 22, 2024

Conversation

coreosbot-releng
Copy link

Requested by @jbtrystram via GitHub workflow (source).

@dustymabe
Copy link
Member

fun - apparently a bunch of other packages now require systemd >= 256 so it's not going to be as easy..

we either need to figure out a way to disable the check temporarily OR pin a bnuch of other packages too

@cgwalters
Copy link
Member

(Or, don't try to gate things like this in FCOS only, but move checks like this into fedora gating itself)

@dustymabe
Copy link
Member

(Or, don't try to gate things like this in FCOS only, but move checks like this into fedora gating itself)

(these comments aren't helpful)

@jlebon
Copy link
Member

jlebon commented May 17, 2024

Reading the depsolve tea leaves, I think adding pins on lvm2-2.03.23-1.fc40.x86_64 and device-mapper-1.02.197-1.fc40 should do it.

Skipping the check would be nice, but requires some cosa work.

(Or, don't try to gate things like this in FCOS only, but move checks like this into fedora gating itself)

I'm confused by this comment. I think you know we already know this would be valuable and that we already did a bunch of work in that area.

jbtrystram added a commit to coreosbot-releng/fedora-coreos-config that referenced this pull request May 21, 2024
Comment on lines 42 to 51
lvm2:
evr: 2.03.23-1.fc40
metadata:
reason: https://github.com/coreos/fedora-coreos-tracker/issues/1735
type: pin
device-mapper:
evr: 1.02.197-1.fc40
metadata:
reason: https://github.com/coreos/fedora-coreos-tracker/issues/1735
type: pin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you grep the lockfile for those EVRs, you'll see there's a bunch of other subpackages we also need to add.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the workflow would support giving multiple Koji/Bodhi URLs. For now, one way to do this is to run the ci/overrides.py pin command locally for each one. (You can see how the add-overrides.yml action uses it.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, added a couple through the correct script (see commit message) and now it builds :)
Thanks for the hint @jlebon !

Changes created with :
ci/overrides.py pin device-mapper-multipath-0.9.7-7.fc40    -r coreos/fedora-coreos-tracker#1735 --ignore-dist-mismatch
ci/overrides.py pin lvm2-2.03.23-1.fc40    -r coreos/fedora-coreos-tracker#1735 --ignore-dist-mismatch

See coreos#3004 (comment)
@jbtrystram jbtrystram force-pushed the override-15824416 branch from c39171d to 11f3a76 Compare May 22, 2024 11:31
@jlebon jlebon enabled auto-merge (rebase) May 22, 2024 12:13
@jlebon jlebon merged commit 06a9dfb into coreos:rawhide May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants