manifests: enable cliwrap on Fedora 40+ #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Feb 16, 2024
As part of the bootable containers effort, we want to put emphasis on a consistent experience when deriving images. A big part of that is being able to type `dnf install -y ...` in one's `Containerfile`. Let's turn on cliwrap for this. This matches the change in FCOS.[[1]] [1]: coreos/fedora-coreos-config#2858
|
Also done in RHCOS in openshift/os#1442. |
As part of the bootable containers effort, we want to put emphasis on a consistent experience when deriving images. A big part of that is being able to type `dnf install -y ...` in one's `Containerfile`. Let's turn on cliwrap for this. This was previously agreed[[1]], but we ended never shipping it since there was a less invasive way to test it.[[2]] Here, we bundle it as part of the Fedora 40 rebase. This will naturally allow it to bake in `branched` and `next` for a while before making it to `stable`. Eventually, once dnf5 is ready, it could take on this role (including package layering on the client-side), at which point we will no longer need to wrap it. [1]: coreos#830 (comment) [2]: coreos#830 (comment)
|
Rebased! As per coreos/fedora-coreos-tracker#730 (comment), I think this is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the bootable containers effort, we want to put emphasis on a consistent experience when deriving images. A big part of that is being able to type
dnf install -y ...in one'sContainerfile.Let's turn on cliwrap for this. This was previously agreed[1], but we ended never shipping it since there was a less invasive way to test it.[2] Here, we bundle it as part of the Fedora 40 rebase. This will naturally allow it to bake in
branchedandnextfor a while before making it tostable.Eventually, once dnf5 is ready, it could take on this role (including package layering on the client-side), at which point we will no longer need to wrap it.