Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for ext.config.kdump.crash test #1708

Merged
merged 5 commits into from
May 4, 2022
Merged

updates for ext.config.kdump.crash test #1708

merged 5 commits into from
May 4, 2022

Conversation

dustymabe
Copy link
Member

@dustymabe dustymabe commented May 2, 2022 •
edited
Loading 

commit 0be55468cac2a70f3f943909202579765a2bef67
Author: Dusty Mabe <[email protected]>
Date:   Wed May 4 14:50:06 2022 -0400

    manifests/fedora-coreos: switch grub2-removals to conditional-include
    
    This move the `arch-include` statments to `conditional-include`, which
    allows us to use `!=`. In this case what we were really trying to target
    was s390x IIUC.

commit 03156146da01544ba434360e91a0042a2879078b
Author: Dusty Mabe <[email protected]>
Date:   Sun May 1 23:01:42 2022 -0400

    manifests/fedora-coreos: fix kdump.crash test for aarch64 AWS
    
    The irqpoll` karg that gets added when the crash kernel is
    started causes issues on AWS aarch64 instances. Let's workaround
    by removing that from `KDUMP_COMMANDLINE_APPEND` in
    `/etc/sysconfig/kdump` for now.
    
    See https://github.com/coreos/fedora-coreos-tracker/issues/1187

commit ccb5447a1afd454ec7d143fec187960f588fadb4
Author: Dusty Mabe <[email protected]>
Date:   Tue May 3 10:24:06 2022 -0400

    tests: kdump.crash: update crashkernel size based on our docs
    
    In our documentation [1] we recommend setting it to 300M as a
    starting baseline. Let's update from 256M to 300M here.
    
    [1] https://docs.fedoraproject.org/en-US/fedora-coreos/debugging-kernel-crashes/

commit d69f0256f667e2351d747cd9523511138bf8f6db
Author: Dusty Mabe <[email protected]>
Date:   Sun May 1 23:13:29 2022 -0400

    tests: kdump.crash: extend timeout
    
    The kdump.crash test on the rawhide stream for aarch64 has started
    taking just longer than 10 minutes. Let's extend the timeout so those
    tests don't timeout and fail the entire run.
    
    Also added comments for the test's kola.json arguments.

commit 7eeb6b738ef3e48b0fdbc0243da1e7f805ca28e6
Author: Dusty Mabe <[email protected]>
Date:   Sun May 1 22:55:45 2022 -0400

    make kdump work on first boot
    
    Up until this point people have had to reboot once after setting up
    kdump so that if a crash happens the crash kernel doesn't get started
    with the ignition.firstboot kernel argument. If we add `ignition.firstboot`
    to the list of arguments in `KDUMP_COMMANDLINE_REMOVE=` in
    `/etc/sysconfig/kdump` then we can set it up on first boot without issues.
    
    Here we also switch the kdump.crash test to set up kdump via Ignition
    to prove out the change works as desired.

@dustymabe dustymabe mentioned this pull request May 2, 2022
Merged
dustymabe
dustymabe commented May 2, 2022
View reviewed changes
manifests/system-configuration.yaml
@@ -37,3 +37,12 @@ packages:
# Boost starving threads
# https://github.com/coreos/fedora-coreos-tracker/issues/753
- stalld

postprocess:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added here so we can share with RHCOS.

mike-nguyen
mike-nguyen requested changes May 2, 2022
View reviewed changes
Copy link
Member

@mike-nguyen mike-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally and the symlink to commonlib.sh is broken. It's a relative symlink and the test is one level deeper.

tests/kola/kdump/crash/config.bu Outdated Show resolved Hide resolved
@mike-nguyen
Copy link
Member

Related PRs/Issues that can be closed if this merges

@dustymabe dustymabe force-pushed the dusty-kdump branch 2 times, most recently from c9c2a8f to c8073fb Compare May 4, 2022 18:51
dustymabe added 3 commits May 4, 2022 14:56
@dustymabe
make kdump work on first boot
7eeb6b7 
Up until this point people have had to reboot once after setting up
kdump so that if a crash happens the crash kernel doesn't get started
with the ignition.firstboot kernel argument. If we add `ignition.firstboot`
to the list of arguments in `KDUMP_COMMANDLINE_REMOVE=` in
`/etc/sysconfig/kdump` then we can set it up on first boot without issues.

Here we also switch the kdump.crash test to set up kdump via Ignition
to prove out the change works as desired.
@dustymabe
tests: kdump.crash: extend timeout
d69f025 
The kdump.crash test on the rawhide stream for aarch64 has started
taking just longer than 10 minutes. Let's extend the timeout so those
tests don't timeout and fail the entire run.

Also added comments for the test's kola.json arguments.
@dustymabe
tests: kdump.crash: update crashkernel size based on our docs
ccb5447 
In our documentation [1] we recommend setting it to 300M as a
starting baseline. Let's update from 256M to 300M here.

[1] https://docs.fedoraproject.org/en-US/fedora-coreos/debugging-kernel-crashes/
@dustymabe dustymabe force-pushed the dusty-kdump branch 2 times, most recently from 0be5546 to f49f403 Compare May 4, 2022 19:06
dustymabe added 2 commits May 4, 2022 15:08
@dustymabe
manifests/fedora-coreos: fix kdump.crash test for aarch64 AWS
aebeaba 
The irqpoll` karg that gets added when the crash kernel is
started causes issues on AWS aarch64 instances. Let's workaround
by removing that from `KDUMP_COMMANDLINE_APPEND` in
`/etc/sysconfig/kdump` for now.

See coreos/fedora-coreos-tracker#1187
@dustymabe
manifests/fedora-coreos: switch grub2-removals to conditional-include
9aa849a 
This move the `arch-include` statments to `conditional-include`, which
allows us to use `!=`. In this case what we were really trying to target
was s390x IIUC.
mike-nguyen
mike-nguyen approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@mike-nguyen mike-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member Author

CI flaked on coreos/fedora-coreos-tracker#1190

@dustymabe dustymabe enabled auto-merge (rebase) May 4, 2022 20:03
@dustymabe dustymabe merged commit 22555a4 into coreos:testing-devel May 4, 2022
@dustymabe dustymabe deleted the dusty-kdump branch May 4, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miabbott miabbott miabbott left review comments

@bgilbert bgilbert bgilbert left review comments

@mike-nguyen mike-nguyen mike-nguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dustymabe @mike-nguyen @bgilbert @miabbott