Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x: add zipl parameter #146

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Conversation

tuan-hoang1
Copy link
Contributor

This will be read by s390x zipl bootloader during
cosa buildextend-installer

This will be read by s390x zipl bootloader during
cosa buildextend-installer
@ajeddeloh
Copy link
Contributor

Are we still building the installer with anaconda? The installer should just be the initrd and kernel from the normal build, which should have these args as a result of that, right?

@tuan-hoang1
Copy link
Contributor Author

tuan-hoang1 commented Aug 21, 2019

This is for FCOS thus no anaconda.
Basically I just copy these 2 from isolinux files: https://github.com/coreos/fedora-coreos-config/blob/testing-devel/installer/isolinux/isolinux.cfg#L68
rd.neednet=1 might be already there as a result of a normal build, but coreos.inst=yes seems to be required here ?

@cgwalters
Copy link
Member

Are we still building the installer with anaconda?

We never did that (on any arch).

@ajeddeloh
Copy link
Contributor

We never did that (on any arch).

Oh right, I was conflating the BM images and the installer.

Copy link
Contributor

@ajeddeloh ajeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters cgwalters merged commit caa4de2 into coreos:testing-devel Aug 21, 2019
dustymabe pushed a commit to jbtrystram/fedora-coreos-config that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants