Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move "discovery" to "internal/discovery" #9233

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 25, 2018

For #9220.

@gyuho gyuho requested a review from xiang90 January 25, 2018 22:33
@gyuho gyuho changed the title *: move "discovery" to "internal/discovery" *: rename "discovery" to "internal/discovery" Jan 25, 2018
@gyuho gyuho changed the title *: rename "discovery" to "internal/discovery" *: move "discovery" to "internal/discovery" Jan 25, 2018
@codecov-io
Copy link

codecov-io commented Jan 25, 2018

Codecov Report

Merging #9233 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9233      +/-   ##
==========================================
+ Coverage   75.78%   75.92%   +0.14%     
==========================================
  Files         363      363              
  Lines       30190    30190              
==========================================
+ Hits        22880    22923      +43     
+ Misses       5708     5670      -38     
+ Partials     1602     1597       -5
Impacted Files Coverage Δ
etcdmain/etcd.go 50.43% <ø> (ø) ⬆️
etcdserver/server.go 79.51% <ø> (ø) ⬆️
internal/discovery/discovery.go 74.03% <ø> (ø)
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
pkg/netutil/netutil.go 66.66% <0%> (-2.09%) ⬇️
clientv3/watch.go 95.58% <0%> (-0.25%) ⬇️
clientv3/namespace/watch.go 93.93% <0%> (ø) ⬆️
clientv3/health_balancer.go 85.97% <0%> (ø) ⬆️
etcdserver/v3_server.go 81.65% <0%> (+0.51%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798586b...432581c. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Jan 25, 2018

not sure about this one. discovery is a client side thing, not sure if people depend on it today.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 25, 2018

It's only used in etcdmain and etcdserver? GitHub and Google search results show no use of this package outside of etcd.

@xiang90
Copy link
Contributor

xiang90 commented Jan 25, 2018

if it is the case, then lgtm

@gyuho gyuho merged commit 6faeddb into etcd-io:master Jan 26, 2018
@gyuho gyuho deleted the discovery branch January 26, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants