Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: reorganize "internal" Go packages #9220

Closed
gyuho opened this issue Jan 24, 2018 · 5 comments
Closed

all: reorganize "internal" Go packages #9220

gyuho opened this issue Jan 24, 2018 · 5 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 24, 2018

Packages like "alarm" and "compactor" are not expected to be used outside of etcd project.

Move all internal packages under /internal/*.

@xiang90
Copy link
Contributor

xiang90 commented Jan 26, 2018

lease, mvcc, store should be moved too.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 26, 2018

@mitake Could you double-check if it's safe to move auth to internal/auth?

"github.com/coreos/etcd/auth" is not meant to be used directly by clients. All errors are converted to rpctypes, so moving to internal won't break anything (e.g. clients will still receives error typed rpctypes.ErrRoleAlreadyExist, not auth.ErrRoleAlreadyExist).

Also seems like there's no external project that imports "github.com/coreos/etcd/auth", based on github and Google search results.

@mitake
Copy link
Contributor

mitake commented Jan 29, 2018

@gyuho ok, I'll look at it

@mitake
Copy link
Contributor

mitake commented Jan 29, 2018

Moving the package to internal won't cause problems, I think. Should I create a PR for this? @gyuho

@gyuho
Copy link
Contributor Author

gyuho commented Jan 29, 2018

@mitake Sure! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants