This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
backup operator: fixed incorrect backup file naming convention. #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@etcd-bot ok to test |
|
@kapouille it looks like we missed this line in the tests |
kapouille
force-pushed
the
snapshot_naming_fix
branch
from
a18b469
to
6a215d5
Compare
When limiting the number of backups, if the revision would move to needing another digit, the logic would never select a new entry as _ is > to 9 in ascii terms. Note that this is backwards incompatible as now files receive a correct padding and old revisions will still be incorrectly handled.
kapouille
force-pushed
the
snapshot_naming_fix
branch
from
6a215d5
to
b1bbc88
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When limiting the number of backups, if the revision would move to needing another digit, the logic would never select a new entry as _ is > to 9 in ascii terms.
Note that this is backwards incompatible as now files receive a correct padding and old revisions will still be incorrectly handled.