This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please pay attention to:
|
@hongchaodeng tried again. PTAL |
hongchaodeng
reviewed
Jan 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pkg/apis/etcd/v1beta2/cluster.go
Outdated
@@ -24,7 +24,7 @@ import ( | |||
|
|||
const ( | |||
defaultRepository = "quay.io/coreos/etcd" | |||
defaultVersion = "3.2.11" | |||
DefaultVersion = "3.2.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DefaultEtcdVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
fanminshi
force-pushed
the
bump_etcd_3.2.13
branch
from
January 2, 2018 23:02
efbf711
to
4ff993b
Compare
merge when green |
Before merging, please check the e2eslow log to verify the panic message is gone. |
will do! |
fanminshi
force-pushed
the
bump_etcd_3.2.13
branch
2 times, most recently
from
January 3, 2018 00:20
5d3b691
to
ec645e0
Compare
fanminshi
force-pushed
the
bump_etcd_3.2.13
branch
from
January 3, 2018 00:24
ec645e0
to
6e889fc
Compare
no panic in the e2eslow logs. merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump etcd version to 3.2.13 in many places.
exposed DefaultVersion allowing backup_restore_test.go to use it to compare
backup status with the default etcd version.
fixes #1813