Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the commented line in the cosa shell fucntion #957

Merged
merged 1 commit into from
Nov 29, 2019
Merged

remove the commented line in the cosa shell fucntion #957

merged 1 commit into from
Nov 29, 2019

Conversation

gabx
Copy link
Contributor

@gabx gabx commented Nov 29, 2019

Writing the cosa() function as indicated in the README let us with an error when running the function.

$ cosa shell
cosa:2: bad pattern: # 

Removing the offending part # so we can see what command gets run remove this issue.

$ cosa shell
+cosa:3> podman run ....
bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell
[coreos-assembler]$

@jlebon
Copy link
Member

jlebon commented Nov 29, 2019

cosa:2: bad pattern: #

Hmm, I can't reproduce this locally. What does alias cosa say after you've defined it?

README.md Outdated Show resolved Hide resolved
@gabx
Copy link
Contributor Author

gabx commented Nov 29, 2019

cosa:2: bad pattern: #

Hmm, I can't reproduce this locally. What does alias cosa say after you've defined it?

What do you mean by alias cosa say after you've defined it ?
I am on zsh, maybe the reason why my shell won't take the commented part?

@jlebon
Copy link
Member

jlebon commented Nov 29, 2019

I am on zsh, maybe the reason why my shell won't take the commented part?

Ahh, maybe you're hitting https://stackoverflow.com/a/11873793?

Though removing the comment WFM too! I think it's clear already what the goal of that line is. Maybe just drop that second commit and I'll fix it up separately?

This breaks on the default Zsh configuration. See:
#957
@jlebon jlebon merged commit d96c7fb into coreos:master Nov 29, 2019
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants