create_disk: use zipl bootloader for libostree on s390x #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s390x requires running `zipl` to regenerate the bootloader block after changes to the BLS configuration are made. (Note this backend doesn't exist yet, but it will)
|
Requires: ostreedev/ostree#1937 Though hmm, should be fine to merge this one already I suppose since the status quo is broken anyway, right? |
|
Not quite sure, because 'none' might be a valid bootloader while 'zipl' might be not. |
|
This one should be clear to merge now right? |
tuan-hoang1
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s390x requires running
ziplto regenerate the bootloader blockafter changes to the BLS configuration are made.
(Note this backend doesn't exist yet, but it will)