Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow image.yaml to specify extra kernel args #525

Merged
merged 1 commit into from
May 17, 2019
Merged

Allow image.yaml to specify extra kernel args #525

merged 1 commit into from
May 17, 2019

Conversation

bgilbert
Copy link
Contributor

FCOS wants to disable SMT by default; RHCOS doesn't.

coreos/fedora-coreos-tracker#181

@bgilbert bgilbert mentioned this pull request May 17, 2019
Merged
@dustymabe
Copy link
Member

LGTM - testing now

@dustymabe
Copy link
Member

works - I see this on a booted system:

BOOT_IMAGE=/ostree/fedora-coreos-46ee1edf31fb787001331562892595d984ddc256eb9f1e276bc9073d2c6bf53d/vmlinuz-5.0.16-300.fc30.x86_64 console=tty0 console=ttyS0,115200n8 rootflags=defaults,prjquota rw mitigations=auto,nosmt ignition.firstboot rd.neednet=1 ip=dhcp root=UUID=5dea024a-465e-44d9-b346-34c082caa2ac ostree=/ostree/boot.0/fedora-coreos/46ee1edf31fb787001331562892595d984ddc256eb9f1e276bc9073d2c6bf53d/0 ignition.platform.id=qemu

holding on merge for now until we resolve coreos/fedora-coreos-config#95 (comment)

@bgilbert
Allow image.yaml to specify extra kernel args
6afc55d 
FCOS wants to disable SMT by default; RHCOS doesn't.
@bgilbert
Copy link
Contributor Author

Updated.

jlebon
jlebon approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will leave the final merge to @dustymabe.

@dustymabe dustymabe merged commit c4e6ff1 into coreos:master May 17, 2019
@bgilbert bgilbert deleted the kargs branch May 17, 2019 18:18
@cgwalters cgwalters mentioned this pull request Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgilbert @dustymabe @jlebon