Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosalib/container_manifest.py: account for images that are repo:tag #4007

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

dustymabe
Copy link
Member

enhance the garbage collection for the repo:tag we are trying to create a container image manifest for. In this case we were getting an error because someone had pulled the
quay.io/coreos-assembler/coreos-assembler:main image down from quay. It wasn't a manifest listed repo:tag so podman manifest exists wasn't returning true, but the create would fail.

The updated code here should handle this case.

This enhances the previous effort in 01e4e55.

marmijo
marmijo previously approved these changes Jan 24, 2025
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member Author

oh fun.. CI trouble:

16:30:05  - jnlp -- terminated (2)
16:30:05  -----Logs-------------
16:30:05  2025/01/24 21:30:04 [go-init] No pre-start command defined, skip
16:30:05  2025/01/24 21:30:04 [go-init] Main command launched : /usr/local/bin/run-jnlp-client
16:30:05  panic: runtime error: invalid memory address or nil pointer dereference
16:30:05  [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4a6f52]
16:30:05  
16:30:05  goroutine 17 [running]:
16:30:05  main.run.func1()
16:30:05  	/go/src/github.com/openshift/jenkins/go-init/main.go:161 +0x92
16:30:05  created by main.run
16:30:05  	/go/src/github.com/openshift/jenkins/go-init/main.go:155 +0x22f

@dustymabe dustymabe enabled auto-merge (rebase) January 24, 2025 21:37
enhance the garbage collection for the repo:tag we are trying
to create a container image manifest for. In this case we were
getting an error because someone had pulled the
quay.io/coreos-assembler/coreos-assembler:main image down from
quay. It wasn't a manifest listed repo:tag so `podman manifest exists`
wasn't returning true, but the create would fail.

The updated code here should handle this case.

This enhances the previous effort in 01e4e55.
@dustymabe dustymabe merged commit 69f5874 into coreos:main Jan 25, 2025
5 checks passed
@dustymabe dustymabe deleted the dusty-push-container-fix branch January 25, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants