tests/containers: add a NFS server containers #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Oct 31, 2024
This is prep work for enabling kdump over NFS testing. The previous attempt in coreos#3911 used an image from openshift E2E tests, but I didn't pay attention to the image and the latest tag is not a multiarch manifest, so the pipeline tripped on that. Building the image ourselves will fix that.
jbtrystram
force-pushed
the
nfs-container
branch
from
38686ee to
2ded27f
Compare
dustymabe
reviewed
Oct 31, 2024
Comment on lines
+56
to
+59
| # Ugly hack to do nothing and wait for SIGTERM | ||
| while true; do | ||
| sleep 5 | ||
| done |
There was a problem hiding this comment.
we use a while loop here to get log messages to show a heartbeat essentially (that it's not frozen)? Might also be nice to get a timestamp printed too.
|
could you update the list of things to update on rebase with these test/ containers? |
it's already there. coreos/fedora-coreos-tracker@b38adf2 |
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Nov 3, 2024
This way we have good coverage of most-used kdump features. Some context on the NFS kdump configuration: coreos/fedora-coreos-tracker#1729 This was previously merged in [1] then reverted in [2] because the nfs server container was not multi-arch, causing the pipeline to trip on it. It's also not functionning on systemd256 (so anything f41 and above), see [3] This requires coreos#3917 for the multi-arch container, and coreos#3921 [1] coreos@b10d8dc [2] coreos@af1468c [3] rhkdump/kdump-utils#52
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Nov 3, 2024
This way we have good coverage of most-used kdump features. Some context on the NFS kdump configuration: coreos/fedora-coreos-tracker#1729 This was previously merged in [1] then reverted in [2] because the nfs server container was not multi-arch, causing the pipeline to trip on it. It's also not functionning on systemd256 (so anything f41 and above), see [3] This requires coreos#3917 for the multi-arch container, and coreos#3921 [1] coreos@b10d8dc [2] coreos@af1468c [3] rhkdump/kdump-utils#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prep work for enabling kdump over NFS testing. The previous attempt in #3911 used an image from openshift E2E tests, but I didn't pay attention to the image and the latest tag is not a multiarch manifest, so the pipeline tripped on that.
Building the image ourselves will fix that.