-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ppc64le] Use XICS Interrupt Controller #3898
Conversation
Using this interrupt controller will remove this warning from test output: qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM The previous link was 404. More info about pseries and XICS in new link. Signed-off-by: Mick Tarsel <[email protected]>
Hi @mtarsel. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
// https://qemu.readthedocs.io/en/latest/system/ppc/pseries.html#switching-between-the-kvm-pr-and-kvm-hv-kernel-module | ||
"-machine", "pseries,kvm-type=HV," + machineArg, | ||
// https://www.qemu.org/docs/master/system/ppc/pseries.html | ||
"-machine", "pseries,kvm-type=HV,ic-mode=xics," + machineArg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify why not use XIVE
? Or it is suppose to work only with LPARs?
Seems XICS is for P8 and and XIVE for P9 and P10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For KVM-HV hypervisor running in a pseries-guest native xive mode is currently not supported, but rather native xics.
Qemu by default will attempt enabling native xive for pseries guests first and if that fails , fallsback to xics based interrupts hence this warning is emitted.
Explicitly asking Qemu to use xics base interrupt controller forces qemu to not attempt to use XIVE interrupt controller preventing this warning message from being emmited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the clarification @vaibhav92!
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/retest |
/ok-to-test |
Using this interrupt controller will remove this warning from test output:
The previous link was 404. More info about pseries and XICS in new link.
Related to issue #2473