Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ppc64le] Use XICS Interrupt Controller #3898

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mtarsel
Copy link
Contributor

@mtarsel mtarsel commented Oct 4, 2024

Using this interrupt controller will remove this warning from test output:

qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM

Falling back to kernel-irqchip=off

The previous link was 404. More info about pseries and XICS in new link.

Related to issue #2473

Using this interrupt controller will remove this warning from test output:

qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM

The previous link was 404. More info about pseries and XICS in new link.

Signed-off-by: Mick Tarsel <[email protected]>
Copy link

openshift-ci bot commented Oct 4, 2024

Hi @mtarsel. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

// https://qemu.readthedocs.io/en/latest/system/ppc/pseries.html#switching-between-the-kvm-pr-and-kvm-hv-kernel-module
"-machine", "pseries,kvm-type=HV," + machineArg,
// https://www.qemu.org/docs/master/system/ppc/pseries.html
"-machine", "pseries,kvm-type=HV,ic-mode=xics," + machineArg,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify why not use XIVE? Or it is suppose to work only with LPARs?
Seems XICS is for P8 and and XIVE for P9 and P10?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For KVM-HV hypervisor running in a pseries-guest native xive mode is currently not supported, but rather native xics.
Qemu by default will attempt enabling native xive for pseries guests first and if that fails , fallsback to xics based interrupts hence this warning is emitted.

Explicitly asking Qemu to use xics base interrupt controller forces qemu to not attempt to use XIVE interrupt controller preventing this warning message from being emmited.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the clarification @vaibhav92!
LGTM!

@ravanelli ravanelli requested review from dustymabe and jlebon October 21, 2024 19:55
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ravanelli
Copy link
Member

/retest

@ravanelli
Copy link
Member

/ok-to-test

@ravanelli ravanelli merged commit 7653b93 into coreos:main Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants