-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/prune-containers: add a GC script for containers images #3826
Conversation
52858ef
to
844d6c1
Compare
Also, typo in the commit and PR title: s/contaiers/containers/ :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just the exit(1)
bit needs fixing. The rest LGTM as is.
Rework the duration parsing code to support days, weeks, months and years. Also use a regexp so we don't need the space. In preparation for the container garbage collection code, which will consume the same policy files, move the code to the shared cosalib. Also updates the parse_fcos_version to returns the stream id in a tuple along the build timestamp.
Ok I rebased and updated this PR since #3798 landed. I made a couple of refactorings in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One comment, but LGTM as is!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm
/test rhcos |
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
/override ci/prow/rhcos |
@jbtrystram: jbtrystram unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Prow failing on openshift/os#1551. /override ci/prow/rhcos |
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure.
If no duration is specified, no image will be pruned.
See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995