Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.10] mantle: overhaul azure authentication #3366

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

dustymabe
Copy link
Member

This is a partial backport of 50f6205. Rather than doing any library changes here (since the versions of libraries on these older branches are mostly frozen in time) we are just picking up the changes to the credentials file we use as input where we now have a single azureCreds.json rather than two (azureProfile.json and azureAuth.json).

In order to support this I still need to get the information back into a AZURE_AUTH_LOCATION formatted file for the old library to be able to read the data. For now we'll just write it out to a temporary file that gets cleaned up immediately after use. This isn't great, but the limited usage here only for older branches executed in our downstream pipeline makes it less of a concern.

(cherry picked from commit 92daef1)

This is a partial backport of 50f6205. Rather than doing any
library changes here (since the versions of libraries on these
older branches are mostly frozen in time) we are just picking up
the changes to the credentials file we use as input where we now
have a single azureCreds.json rather than two (azureProfile.json
and azureAuth.json).

In order to support this I still need to get the information back
into a AZURE_AUTH_LOCATION formatted file for the old library to be
able to read the data. For now we'll just write it out to a temporary
file that gets cleaned up immediately after use. This isn't great,
but the limited usage here only for older branches executed in our
downstream pipeline makes it less of a concern.

(cherry picked from commit 92daef1)
@dustymabe
Copy link
Member Author

this is failing in CI for unknown reasons when trying to checkout the repo to run make check && make unittest. I ran make check && make unittest locally and it passed so I'll merge this so we don't block re-enabling the downstream pipeline.

@dustymabe dustymabe merged commit 3bd8e90 into coreos:rhcos-4.10 Feb 21, 2023
@dustymabe dustymabe deleted the dusty-410-azure-backport branch February 21, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants