build: Add support for automatic overrides in overrides/rpm
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user creates a directory `overrides/rpm`, automatically run `createrepo_c` on it every build, and generate a new treefile that adds it as a repo. Closes: coreos#118
|
This one had been sitting in my local git dir for quite a while blocked on coreos/rpm-ostree#1574 which had been blocking on other stuff...getting through the queue! |
|
(One confusing issue here is that simply adding the repository changes the treefile which makes rpm-ostree think something changed - so if e.g. your override RPM is a lower NVR we'll just ignore it; I will look at repo priority stuff at some point) |
|
One hack we could do to help with that is injecting every package we find in |
|
LGTM |
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Feb 25, 2019
Adds note regarding changes in coreos#145 - personally found this helpful when testing Ignition changes in FCOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user creates a directory
overrides/rpm, automaticallyrun
createrepo_con it every build, and generate a newtreefile that adds it as a repo.
Closes: #118