Fixes related to kola/qemu on aarch64

[jcajka]

Adds UEFI support in to kola/qemu for aarch64. Change a bit kola options around uefi and swtpm(default to off). I hope I have not missed any places. Tested on x86_64, aarch64 and ppc64le.

[cgwalters]

Thanks for working on this!
/approve

[Prashanth684]

@jcajka I was executing testiso on rhcos for the legacy install scenario with this PR and i see:
Error: scenario legacy-install: running PXE: legacy installer: Unsupported arch %!s(MISSING)aarch64

Looks like you need to add the case statement to support aarch64 here: https://github.com/coreos/coreos-assembler/blob/master/mantle/platform/metal.go#L291

[jcajka]

@jcajka I was executing testiso on rhcos for the legacy install scenario with this PR and i see:
Error: scenario legacy-install: running PXE: legacy installer: Unsupported arch %!s(MISSING)aarch64

Looks like you need to add the case statement to support aarch64 here: https://github.com/coreos/coreos-assembler/blob/master/mantle/platform/metal.go#L291

That is possible. I have not tried PXE metal on aarch64. Not that far yet. BTW do you know what is expected there for AArch64?(PXE wise)

[Prashanth684]

@jcajka I was executing testiso on rhcos for the legacy install scenario with this PR and i see:
Error: scenario legacy-install: running PXE: legacy installer: Unsupported arch %!s(MISSING)aarch64
Looks like you need to add the case statement to support aarch64 here: https://github.com/coreos/coreos-assembler/blob/master/mantle/platform/metal.go#L291

That is possible. I have not tried PXE metal on aarch64. Not that far yet. BTW do you know what is expected there for AArch64?(PXE wise)

Ah..i see my bad... i thought this PR was addressing everything for aarch64. For PXE i think we need to find the UEFI boot image to point to and the network device. I don't want to hijack this PR with that discussion. That can be separate.

[jcajka]

@jcajka I was executing testiso on rhcos for the legacy install scenario with this PR and i see:
Error: scenario legacy-install: running PXE: legacy installer: Unsupported arch %!s(MISSING)aarch64
Looks like you need to add the case statement to support aarch64 here: https://github.com/coreos/coreos-assembler/blob/master/mantle/platform/metal.go#L291

That is possible. I have not tried PXE metal on aarch64. Not that far yet. BTW do you know what is expected there for AArch64?(PXE wise)

Ah..i see my bad... i thought this PR was addressing everything for aarch64. For PXE i think we need to find the UEFI boot image to point to and the network device. I don't want to hijack this PR with that discussion. That can be separate.

np :). AFAIK PXE has its own quirks on each arch so I'm not sure what is the expected minimum on aarch64 yet(haven't booted any aarch64 via PXE, yet). Will look in to that, I hope soon.

[cgwalters]

One minor thing, otherwise this new version LGTM! Thanks for reworking it, I think it will be clearer to do any arch conditional cleanup separately.

[cgwalters]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jcajka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sohankunkerkar]

/refresh

[jcajka]

@sohankunkerkar it seems to me that the test results didn't got reported here, they seem all green to me.

[jlebon]

/test sanity