mantle/ore: gcloud: add ability to attach license to image #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
builds on top of #1444, for this PR you only need to review the last commit |
dustymabe
force-pushed
the
dusty-ore-gcloud-image-license
branch
2 times, most recently
from
71d5a6d to
596e2df
Compare
|
@dustymabe: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM |
In order to get a dashboard with metrics and such we need to attach our images to "licenses" in GCP. These aren't software licenses but rather how billing and such is done for images that cost money. Ours don't cost anything so it's purely for counting purposes.
dustymabe
force-pushed
the
dusty-ore-gcloud-image-license
branch
from
596e2df to
924093f
Compare
bgilbert
approved these changes
May 14, 2020
bgilbert
suggested changes
May 14, 2020
bgilbert
approved these changes
May 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
|
is prow down? |
|
/retest |
|
ok CI passed, but prow is MIA - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get a dashboard with metrics and such we need to attach
our images to "licenses" in GCP. These aren't software licenses but
rather how billing and such is done for images that cost money. Ours
don't cost anything so it's purely for counting purposes.