Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efi.rs: ensure writable ESP mount #799

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ruihe774
Copy link
Contributor

Just like what we do with /boot.

Copy link

openshift-ci bot commented Dec 13, 2024

Hi @ruihe774. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@travier
Copy link
Member

travier commented Dec 13, 2024

Could you clarify why we need that? Thanks

@ruihe774
Copy link
Contributor Author

Could you clarify why we need that? Thanks

For the scenario that ESP is mounted read-only.

We have the handling for /boot and IMO it is supposed to also have it with /boot/efi. The meaning of mounting /boot read-only is to prevent accidentally modifications to it and I think it is also true for /boot/efi.

@cgwalters
Copy link
Member

/ok-to-test

@cgwalters cgwalters enabled auto-merge December 13, 2024 12:25
@cgwalters cgwalters merged commit 2aa33d2 into coreos:main Dec 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants