-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip UEFI
or BIOS
on none hybrid partition layout
#729
Conversation
The CI will not cover related testing, do some testing manually on none hybrid partition layout: Additional info, need to run on BIOS
on UEFI
|
1274132
to
bb5b41b
Compare
- When booting with `BIOS` and no `ESP` device detected, skip `UEFI` checking - When booting with `UEFI` and no `bios_boot` partition found, skip `BIOS` checking Fixes coreos#717
bb5b41b
to
b1ca767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sane to me...I assume you tested it on the target env?
Yes, see #729 (comment), do some testings on silverblue using BIOS or using UEFI, both work. Will update this according to your suggestion and do testing again. |
I think this can be a followup, no need to block on it. |
SGTM, thanks for the review and pointer! |
BIOS
and noESP
device detected, skipUEFI
checkingUEFI
and nobios_boot
partition found, skipBIOS
checkingFixes #717