grub.cfg: drop set pager=1
#548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was in the very first commit that added a GRUB config to cosa. If set, it causes GRUB to pause output if the screen is full of messages until the user presses a key. That's just incompatible with automation, so nuke it. Any warnings from GRUB should end up in the serial console logs still. One way this can happen is if booting from multipath. GRUB tries each path in turn until it can read from it. For each tried path that's non- optimized, it'll log a message. So if the device has a large enough number of paths, we can trigger the pager functionality and hang boot. Probably fixes: https://issues.redhat.com/browse/OCPBUGS-20123
cgwalters
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was in the very first commit that added a GRUB config to cosa. If set, it causes GRUB to pause output if the screen is full of messages until the user presses a key.
That's just incompatible with automation, so nuke it. Any warnings from GRUB should end up in the serial console logs still.
One way this can happen is if booting from multipath. GRUB tries each path in turn until it can read from it. For each tried path that's non- optimized, it'll log a message. So if the device has a large enough number of paths, we can trigger the pager functionality and hang boot.
Probably fixes: https://issues.redhat.com/browse/OCPBUGS-20123