Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email link. Fixes #1984 #1985

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Remove email link. Fixes #1984 #1985

merged 2 commits into from
Jul 1, 2023

Conversation

david-a-wheeler
Copy link
Collaborator

No description provided.

Email is a terrible issue tracker, and there seems to be problems
with the system we're trying to use.

Instead, tell people to file issues via GitHub, where we can
properly handle and track the issue as an issue.

Signed-off-by: David A. Wheeler <[email protected]>
We had some confusion by people who were trying to
"activate" their local account but had already signed up
via GitHub. This message should help reduce the confusion.

Signed-off-by: David A. Wheeler <[email protected]>
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5b8c017) 98.03% compared to head (1746bcc) 98.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          53       53           
  Lines        2089     2089           
=======================================
  Hits         2048     2048           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@david-a-wheeler david-a-wheeler changed the title Rm email Remove email link. Fixes #1984 Jun 26, 2023
@david-a-wheeler
Copy link
Collaborator Author

I want to give a little time to see if there are any big objections.

@rvagg
Copy link

rvagg commented Jun 27, 2023

#1984 was came about because I had two things to report about the site - one resulted in opening #1983, but the other resulted in an email because it regards user accounts and logins and wasn't really something I wanted to spam in a particularly public way about. Having an email address certainly helps with that!

So this probably depends on how you want to consume these things, without an address I'd have opened a second issue here with a more generic form of my request which would possibly result in us taking it to a more 1:1 forum somehow.

@david-a-wheeler
Copy link
Collaborator Author

@rvagg - yes, GitHub issues are definitely how I'd like to track things. Otherwise it's easy to lose track; it's easy to lose track even with a tracking system!

If it's possibly a vulnerability (and anything about logins sounds like it might be), then please report it as a private issue. Basically, click on "Security", then click on "Report a vulnerability". This is stated in our SECURITY.md file, but if it's not clear enough please let us know how we could make that clearer.

If it's more complicated/weird, or you don't like that process, please do what you suggested - create a vague issue, then follow up details via email. That will reduce the risk of it getting lost.

@david-a-wheeler david-a-wheeler merged commit 227dbd4 into main Jul 1, 2023
@david-a-wheeler david-a-wheeler mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants