Update README.md #4068
Merged
Update README.md #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify that serial must change for the zone file to be reloaded. Signed-off-by: Grant Garrett-Grossman <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4068 +/- ##
==========================================
- Coverage 57.10% 57.08% -0.02%
==========================================
Files 222 222
Lines 11278 11278
==========================================
- Hits 6440 6438 -2
- Misses 4347 4348 +1
- Partials 491 492 +1
Continue to review full report at Codecov.
|
miekg
reviewed
Aug 17, 2020
Co-authored-by: Miek Gieben <[email protected]> Signed-off-by: Grant Garrett-Grossman <[email protected]>
|
/lgtm |
![corbot[bot]](https://avatars.githubusercontent.com/u/21110084?s=60&v=4){kind=small}
zouyee
approved these changes
Aug 20, 2020
nyodas
pushed a commit
to DataDog/coredns
that referenced
this pull request
Oct 26, 2020
* Update README.md Specify that serial must change for the zone file to be reloaded. Signed-off-by: Grant Garrett-Grossman <[email protected]> * Update plugin/auto/README.md Co-authored-by: Miek Gieben <[email protected]> Signed-off-by: Grant Garrett-Grossman <[email protected]> Co-authored-by: Miek Gieben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that serial must change for the zone file to be reloaded.
1. Why is this pull request needed and what does it do?
The caveat that
autoonly automatically reloads the zone file when serial changes was not very clear. This is just a small documentation change to make this clearer. This way, the behavior is mentioned within the scope of the whole plugin and not just within the description of thereloadparameter.2. Which issues (if any) are related?
This is related to the closed issue 4059.
3. Which documentation changes (if any) need to be made?
This is a documentation change.
4. Does this introduce a backward incompatible change or deprecation?
No, unless the behavior of
autoregarding when it reloads the zone file has changed.