Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): executable respect deprecated fields #38

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

Hieuzest
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #38 (7df2410) into master (c91cd43) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   98.05%   98.06%           
=======================================
  Files          23       23           
  Lines        4690     4694    +4     
  Branches     1156     1159    +3     
=======================================
+ Hits         4599     4603    +4     
  Misses         91       91           
Files Changed Coverage Δ
packages/core/src/driver.ts 94.75% <100.00%> (+0.01%) ⬆️
packages/tests/src/selection.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Notice: This pr will no longer allow deprecate fields to be used in db.join(). Although this is not common, it is still possible in db.migrate() callbacks.

@shigma shigma merged commit 663ded3 into cordiverse:master Sep 16, 2023
@Hieuzest Hieuzest deleted the fix-deprecated branch September 28, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants