Put Workflows Jar on a diet - exclude all corda runtime files #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roastario
force-pushed
the
inline_money_and_selection
branch
from
d371c0c to
9d8134d
Compare
chrisr3
reviewed
Jun 8, 2020
| @@ -2,6 +2,11 @@ apply plugin: 'kotlin-jpa' | |||
| apply plugin: 'net.corda.plugins.quasar-utils' | |||
| apply plugin: 'net.corda.plugins.cordapp' | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This entire file ... WTF?!
Why?
If there isn't an easier way of doing this then Gradle Must DIE!!!
There was a problem hiding this comment.
It's an edge case in our fatjarring.
We want to compile in the selection project, but the selection project cordaCompile Corda components, which when you don't use the jar approach results in the entire Corda runtime being included in the fatJar due to transitive dependencies.
The next step is to just move all the logic into workflows.. which I'm seriously considering.
There was a problem hiding this comment.
Yeah, probably would make sense to do so, given that money and selection aren't separate cordapps anymore and unlikely to be used outside of the token sdk.
roastario
added a commit
that referenced
this pull request
Sep 25, 2020
* Make redeem flow handlers open (#199) * Make redeem flow handlers open to allow adding custom processing logic for redeemed tokens on the issuer`s side. Make ObserverAwareFinalityFlowHandler return a SignedTransaction if one was received. * Undo removing a flow Co-authored-by: Stefano Franz <[email protected]> * Put Workflows Jar on a diet - exclude all corda runtime files (#206) * keep * put workflows jar on a bit of a diet * Add serialization env to OwnerMigration * fix migration for 4.6 Co-authored-by: Andrius Dagys <[email protected]> Co-authored-by: Stefano Franz <[email protected]> Co-authored-by: Stefano Franz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.