CORE-12539 - Update to latest version of jackson and mockito #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 25, 2023 10:09
…ransitive dependency and is not a valid OSGi bundle.
…ransitive dependency and is not a valid OSGi bundle.
This is triggered by an Jackson update. See FasterXML/jackson-modules-java8#204 and FasterXML/jackson-modules-java8#267
driessamyn
commented
Apr 26, 2023
| @@ -360,7 +365,7 @@ class RestServerRequestsTest : RestServerTestBase() { | |||
| val timeCallResponse = client.call(POST, WebRequest<Any>("health/timecall", """ { "time": { "time": "$time" } } """), userName, password) | |||
|
|
|||
| assertEquals(HttpStatus.SC_OK, timeCallResponse.responseStatus) | |||
| assertEquals("2020-01-01T11:00Z[UTC]", timeCallResponse.body) | |||
| assertEquals("2020-01-01T11:00Z", timeCallResponse.body) | |||
There was a problem hiding this comment.
This change is triggered by an Jackson update. See FasterXML/jackson-modules-java8#204 and FasterXML/jackson-modules-java8#267
I think this change is ok as the new format is ISO-8601 compatible.
@mnesbit , do you agree this change is ok?
There was a problem hiding this comment.
yes it is fine and indeed probably more canonical
|
Jenkins build for PR 3702 build 4 Build Successful: |
vkolomeyko
changed the title
vkolomeyko
reviewed
Apr 26, 2023
| @@ -56,7 +56,7 @@ felixSecurityVersion=2.8.3 | |||
| guavaVersion=30.1.1-jre | |||
| hibernateVersion=5.6.15.Final | |||
| hikariCpVersion=5.0.1 | |||
| jacksonVersion=2.14.2 | |||
| jacksonVersion=2.15.0 | |||
There was a problem hiding this comment.
Probably as a separate PR, but it would be worth upgrading SnakeYaml version to eliminate reported C1 vulnerability.
vkolomeyko
approved these changes
Apr 26, 2023
driessamyn
deleted the
driessamyn/CORE-12539/5.0GA-dependency-updates-jackson
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.