Added --force to rebuild native modules #511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
--force
flag to the yarn install process so that when installing dependancies, we ensure that native modules are rebuilt.How do I test this PR?
./scripts/docker.sh
FROM coralproject/talk:latest-onbuild
docker build -t coralproject/talk:pr-test .
docker run --rm -ti coralproject/talk:pr-test bash
node models/user.js
There should be an error (specifically about not connecting to the database), but you should no longer see an error related to
bcrypt
not being installed.This issue is related to an upstream issue with yarn: yarnpkg/yarn#756