Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up zio grpc codegen version #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GMadorell
Copy link
Member

No description provided.

@GMadorell GMadorell force-pushed the up-zio-grpc-codegen-version branch from a29b1bb to 8d8591d Compare January 11, 2024 13:32
@GMadorell GMadorell requested a review from zhrebicek January 11, 2024 13:33
@joroKr21
Copy link

Won't this force us to update to ZIO 2?

@zhrebicek
Copy link
Collaborator

It would.

@temo-cx
Copy link

temo-cx commented Jan 18, 2024

@zhrebicek, I also had to update the grpc-codegen version to 6.x, as one of our services utilizes ZIO 2.x, and I needed to include sbt-protobdep. However, it turns out that grpc-codegen 6.1 is incompatible with ZIO 2.x due to a conflicting transitive netty dependency (ZIO 2.x includes an older version of netty, whereas 6.1 introduces a newer one, leading to runtime failures). Consequently, I had to slightly downgrade to grpc-codegen 6.0 and create a separate PR. Have you tried using grpc-codegen 6.1 with ZIO 2.x?

@zhrebicek
Copy link
Collaborator

Feel free to merge it, but at least document that it is breaking change -> required upgrade to ZIO 2.
This thing is also slowly on the way not fixating on any version coralogix/sbt-protofetch#1

@GMadorell
Copy link
Member Author

This thing is also slowly on the way not fixating on any version

Yeah, we might wait until we really need it, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants