Send early spans at the beginning to cover for timeouts and failures #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
approved these changes
Jul 16, 2024
rtimush
approved these changes
Jul 16, 2024
povilasv
approved these changes
Jul 17, 2024
RafalSumislawski
merged commit b067c4d
into
coralogix-python-dev
38 of 582 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is analogous to coralogix/opentelemetry-js-contrib#15 and coralogix/opentelemetry-java-instrumentation#10
These early spans let lambda-telemetry-exporter know in advance what the trace is supposed to look like and if the instrumentation crashes in such a way that it doesn't send the trace, the telemetry-exporter will use these early spans to report something, and indicate the failure.