Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add another lazy import in options.js to reduce bundle size #3665

Merged
merged 1 commit into from
Apr 11, 2023
Merged

add another lazy import in options.js to reduce bundle size #3665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/app-extension/src/options/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
import React, { lazy, Suspense } from "react";
import { lazy, Suspense } from "react";
import { createRoot } from "react-dom/client";

import Options from "./Options";

// Code-splitting keeps the options.js bundle under 4MB which is
// a requirement for Firefox extensions
const Options = lazy(() => import("./Options"));
const LedgerIframe = lazy(() => import("../components/LedgerIframe"));

// Render the UI.
// TOOD(react) createRoot is required: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis
const container = document.getElementById("options");
const root = createRoot(container!);

root.render(
<>
<Options />
<Suspense fallback={null}>
<Options />
</Suspense>
<Suspense fallback={null}>
<LedgerIframe />
</Suspense>
Expand Down