Clear backpack.#publicKey on disconnect #3585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the connect function is not called properly on a reconnect, as #publicKey is already defined
Specifically this is because of this condition in the wallet-standard wrapper (https://github.com/coral-xyz/backpack/blob/master/packages/wallet-standard/src/wallet.ts#L149):
On the first connect,
this.#backpack.publicKey
is undefined andthis.#backpack.connect()
is called correctlyHowever, on the second connect
this.#backpack.publicKey
was already set and sothis.#backpack.connect()
was not called.this.#connected()
was called, and since this usesthis.#backpack.publicKey
it was able to emit an event that made it look to the wallet adapter UI like a connection was successfully performed. But the internal code inthis.#backpack.connect()
hadn't been called, and so signing didn't actually work.The fix is to set
backpack.#publicKey
to undefined on disconnect, so thatthis.#backpack.connect()
is called correctly on the reconnect.Closes #3555