Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return empty array if userIds.length === 0 #3424

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

wentokay
Copy link
Collaborator

sometimes these userIds arrays are empty and zeus strips the filter, so the query gets converted into something like query getUsersMetadata {auth_users(where: {id: {}}) {id username}} which fetches the id and username of all users

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
backpack ✅ Ready (Inspect) Visit Preview Mar 21, 2023 at 0:03AM (UTC)

@github-actions github-actions bot added the backend Related to backend infra, reef or cf workers label Mar 21, 2023
@wentokay wentokay changed the title return empty array if userIds === [] return empty array if userIds.length === 0 Mar 21, 2023
@wentokay wentokay marked this pull request as ready for review March 21, 2023 00:05
@wentokay wentokay merged commit e9d443e into master Mar 21, 2023
@wentokay wentokay deleted the wen/userids-hotfix branch March 21, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend infra, reef or cf workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant