Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pasting images from clipboard #3412

Merged
merged 3 commits into from
Mar 21, 2023
Merged

add support for pasting images from clipboard #3412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
803fd9c
adds support for pasting images from clipboard
AFZL210 Mar 19, 2023
0077e8d
add support pasting images from clipboard
AFZL210 Mar 19, 2023
b1b96c4
Merge branch 'coral-xyz:master' into afzl210/fix2410
AFZL210 Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/chat-sdk/src/components/SendMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export const SendMessage = ({
)}
</IconButton>
</div>
<MessageInput setPluginMenuOpen={setPluginMenuOpen} />
<MessageInput onMediaSelect={onMediaSelect} setPluginMenuOpen={setPluginMenuOpen} />
</div>
{pluginMenuOpen ? (
<div style={{ display: "flex", marginLeft: 8, paddingBottom: 5 }}>
Expand Down
10 changes: 10 additions & 0 deletions packages/chat-sdk/src/components/messageInput/MessageInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,24 @@ export const chatMessageInputId = "backpack-message-input";
export function MessageInput({
setPluginMenuOpen,
autoFocus = true,
onMediaSelect
}: {
setPluginMenuOpen: any;
autoFocus?: boolean;
onMediaSelect: any;
}) {
const classes = useStyles();
const theme = useCustomTheme();
const { type, remoteUsername, activeReply } = useChatContext();
const { activeSearch } = useContext(RichMentionsContext);

const uploadFromClipboard = (e:React.ClipboardEvent<HTMLDivElement>):void => {
if(e.clipboardData.files.length > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any security implications here?

Copy link
Author

@AFZL210 AFZL210 Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it takes the file from the clipboard and passes it to the onMediaSelect method, the file drop feature also uses this. however, I may be wrong. could you please suggest some better practices?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the mime types of the file that's pasted and ensure it's an image/video format?
Also does this work for videos?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll check it now

Copy link
Author

@AFZL210 AFZL210 Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it supports all the file types as it uses the same method that the drop file feature uses and one thing i would like to mention is we can even drop a .js file which is not good. should i add a check in the onMediaSelect function and then only upload it? or it is being handled in the backend?

gif

Backpack.2023-03-20.22-04-03.mp4

video

Backpack.2023-03-20.22-05-32.mp4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cant really prevent people from uploading JS. The security policy of the img tag should prevent any JS to be parsed - https://security.stackexchange.com/questions/135513/what-could-an-img-src-xss-do

If you could create a follow up which prevents any non video/image file in both drag and drops and copy/pastes that would be great

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, i will add it

let file = e.clipboardData.files[0];
onMediaSelect(file)
}
}

useEffect(() => {
if (autoFocus) {
const messageElement = document.getElementById(chatMessageInputId);
Expand All @@ -51,6 +60,7 @@ export function MessageInput({
}}
className={classes.input}
onClick={() => setPluginMenuOpen(false)}
onPaste={(e) => uploadFromClipboard(e)}
placeholder={
type === "individual"
? `Message @${remoteUsername}`
Expand Down